Skip to main content

Dead Code Problem

Problem

Actually this problem occurred when i was doing integration two projects. [Phase1 and phase2 of a project] . Phase 2 is developed on top of the phase1. Parallel phase1 had changed lot . Mean time those were working on phase2 has commented existing phase 1 code without comments . Phase 1 and phase 2 merged with some conflicts. So we commented such places with the descriptive comment . After merged the result code base has merged those phase 2 commented parts. Also there was some of already dead code in phase 1. So it is difficult to understand weather this is actual dead code or commented one from phase 2.

Mistake

Had left dead dead code and missing comments .

Lesson learned

Normally developers leave dead code in their original code with the mind of future purpose. But this not a good habit to continue.As long as you use source control ,earlier code may exist. Problem will occur if you are not using such version control. In such a situation you can keep dead code with descriptive comment . Otherwise omit them . That is the best way to achieve clean code.

Labels:

Comments

Amila Pradeep said…
true. i don't keep any dead code in my code. i used to remove all dead code just after 100% complete the related functionality/ page. but till that final commit, there might be commented lines.
October 16, 2010 at 5:06 AM
Eranga said…
Yes..That is a best practice..Anyway we have to double check to make sure dead code has removed.Otherwise if we commit bulk of pages, we wont remembered we have commented some code. Although slip can be happen.
October 17, 2010 at 4:09 AM
Post a Comment

Popular posts from this blog

MySQL Stored Procedure Error

In our project we had many many stored procedures and many parameters passes to those sps. But in only one sp it gives error message something like this; "Incorrect number of arguments for PROCEDURE sproc_t_l_Contract_Select_BySearchCriteria; expected 3, got 2” Work long time on this sp but coudnt find it. So i tried to write it again from the begining. In this time it was work perfectly.This problem occurs because of the space between data type and its length. Ex. pName varchar(50) - working pName varchar (50) - Not working But it does not mention syntax error or something.So this error message make us vulnerable.
1 comment
Read more

The transaction is in doubt

Sometimes you may get this error when you use transaction scope . The transaction is in doubt I also got this error recently and able to find the reason for it. That is because of the some of the readers had not properly disposed. Actually in this case you can use Using keyword to overcome this. Exception : System.Transactions.TransactionInDoubtException was unhandled by user code Message="The transaction is in doubt." Solution : using (reader) { }
1 comment
Read more

Appreciation

Today I got this touching email: One young academically excellent person went to apply for a managerial position in a big company. He passed the first interview, the director did the last interview, made the last decision. The director discovered from the CV,  that the youth's academic result is excellent all the way, from the secondary school until the postgraduate research, never has a year he did not score. The director asked, "Did you obtain any scholarship in school?" and the youth answered "none". The director asked, " Is it your father pay for your school fees?" the youth answered, my father passed away when I was one year old, it is my mother who paid for my school fees. The director asked, " Where did your mother worked?" the youth answered, my mother worked as cloth cleaner. The director requested the youth to show his hand, the youth showed a pair of hand that is smooth and perfect to the ...
Post a Comment
Read more